Missing some titles in the jsguide.html file, under "3 Source file structure" title + seeing the table of contents with delay .#655
Open
ellietms wants to merge 1 commit intogoogle:gh-pagesfrom
Conversation
ellietms
changed the title
ellietms
changed the title
devvsakib
approved these changes
Feb 23, 2023
devvsakib
left a comment
devvsakib
left a comment
There was a problem hiding this comment.
it's not mandatory to use a comma after the last element, also single quote or double quote doesn't matter.
LGTM
vapier
requested changes
Jul 8, 2024
Member
vapier
left a comment
vapier
left a comment
There was a problem hiding this comment.
it's hard to tell functional from style changes in here. please create a separate PR/commit for just the style changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I realised we are missing some titles under the 3 Source file structure section.
JavascriptGuide
it shows us 3.3 and we do not have 3.3.1, 3.3.2 but we have 3.3.3.
The Table contents are being created inside of the "include/jsguide.js" with pure javascript.
I added some comments that where I think the issue is happening.
one more thing is when I refresh the page, it takes longer for me to see all the links in my table of contents.
It is slow.